[CIR] Extend CIR canonicalize to rewrite ptr_stride and array_to_ptrdecay to get_element when possible
#1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_ptrdecay` operations that can be simplified to `get_element` Extended the `CIRCanonicalizePass` with new rewrite rules: Rewrite `ptr_stride (cast array_to_ptrdecay %base), %index` to `get_element %base[%index]` Rewrite `ptr_stride (get_element %base[%index]), %stride` to `get_element %base[%index + %stride]` Rewrite `cast array_to_ptrdecay %base, ptr<T>` to `get_element %base[0], ptr<T>` if it is only used by `load %ptr : T`, `store %val : T, %ptr`, or `get_member %ptr[field] : ptr<T> -> U`
xlauko
reviewed
Jul 26, 2025
…<T>()` Co-authored-by: Henrich Lauko <[email protected]>
Co-authored-by: Henrich Lauko <[email protected]>
Co-authored-by: Henrich Lauko <[email protected]>
Collaborator
Author
|
Thanks for the review @xlauko, I've applied to requested changes. |
bcardosolopes
approved these changes
Jul 28, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
I already reviewed this internally, so no extra feedback. Please double check if you can also upstream this when you have the bandwidth. LGTM
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
…trdecay` to `get_element` when possible (llvm#1761) Extended the `CIRCanonicalizePass` with new rewrite rules: - Rewrite `ptr_stride (cast array_to_ptrdecay %base), %index` to `get_element %base[%index]` - Rewrite `ptr_stride (get_element %base[%index]), %stride` to `get_element %base[%index + %stride]` - Rewrite `cast array_to_ptrdecay %base, ptr<T>` to `get_element %base[0], ptr<T>` if it is only used by `load %ptr : T`, `store %val : T, %ptr`, or `get_member %ptr[field] : ptr<T> -> U` Updated CodeGen tests, and extended CIR-to-CIR test. --------- Co-authored-by: Henrich Lauko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the
CIRCanonicalizePasswith new rewrite rules:ptr_stride (cast array_to_ptrdecay %base), %indextoget_element %base[%index]ptr_stride (get_element %base[%index]), %stridetoget_element %base[%index + %stride]cast array_to_ptrdecay %base, ptr<T>toget_element %base[0], ptr<T>if it is only used byload %ptr : T,store %val : T, %ptr, orget_member %ptr[field] : ptr<T> -> UUpdated CodeGen tests, and extended CIR-to-CIR test.