Skip to content

[CIR] Implement CK_LValueToRValueBitCast for ComplexType #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

[CIR] Implement CK_LValueToRValueBitCast for ComplexType #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aee4ec9
[CIR] Implement CK_LValueToRValueBitCast for ComplexType
AmrDeveloper Jul 21, 2025
c3fe763
Update the test snippets
AmrDeveloper Jul 25, 2025
b70bb5e
Merge branch 'main' into cir_complex_lvalue_to_rvalue_bc
AmrDeveloper Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,14 @@ mlir::Value ComplexExprEmitter::emitCast(CastKind CK, Expr *Op,
case CK_LValueBitCast:
llvm_unreachable("NYI");

case CK_LValueToRValueBitCast:
llvm_unreachable("NYI");
case CK_LValueToRValueBitCast: {
LValue SourceLVal = CGF.emitLValue(Op);
Address Addr = SourceLVal.getAddress().withElementType(
Builder, CGF.convertTypeForMem(DestTy));
LValue DestLV = CGF.makeAddrLValue(Addr, DestTy);
DestLV.setTBAAInfo(TBAAAccessInfo::getMayAliasInfo());
return emitLoadOfLValue(DestLV, Op->getExprLoc());
}

case CK_BitCast:
case CK_BaseToDerived:
Expand Down
23 changes: 23 additions & 0 deletions clang/test/CIR/CodeGen/complex-cast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,29 @@ void complex_to_bool() {

// CHECK: }

struct CX {
double real;
double imag;
};

void lvalue_to_rvalue_bitcast() {
struct CX a;
double _Complex b = __builtin_bit_cast(double _Complex, a);
}

// CHECK-LABEL: @lvalue_to_rvalue_bitcast()

// CIR-BEFORE: %{{.+}} = cir.cast(bitcast, %{{.+}} : !cir.ptr<!rec_CX>), !cir.ptr<!cir.complex<!cir.double>>

// CIR-AFTER: %{{.+}} = cir.cast(bitcast, %{{.+}} : !cir.ptr<!rec_CX>), !cir.ptr<!cir.complex<!cir.double>>

// LLVM: %[[PTR_ADDR:.*]] = alloca %struct.CX, i64 1, align 8
// LLVM: %[[COMPLEX_ADDR:.*]] = alloca { double, double }, i64 1, align 8
// LLVM: %[[PTR_TO_COMPLEX:.*]] = load { double, double }, ptr %[[PTR_ADDR]], align 8
// LLVM: store { double, double } %[[PTR_TO_COMPLEX]], ptr %[[COMPLEX_ADDR]], align 8

// CHECK: }

void complex_to_complex_cast() {
cd = cf;
ci = cs;
Expand Down
Loading