-
Notifications
You must be signed in to change notification settings - Fork 183
[CIR] Implement function alias lowering #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This updates the lowering of CIR function aliases in such a way that they now actually become aliases in the final LLVM IR.
xlauko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, modulo minor nits
bcardosolopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support to this, I added AliasOp to LLVM dialect but didn't get the chance to lower it from CIR! As you noted creating it requires an extra region, just like most versions of LLVM_GlobalOp.
LGTM after some nits
This updates the lowering of CIR function aliases in such a way that they now actually become aliases in the final LLVM IR.
This updates the lowering of CIR function aliases in such a way that they now actually become aliases in the final LLVM IR.