Skip to content

Conversation

@andykaylor
Copy link
Collaborator

This updates the lowering of CIR function aliases in such a way that they now actually become aliases in the final LLVM IR.

This updates the lowering of CIR function aliases in such a way
that they now actually become aliases in the final LLVM IR.
Copy link
Collaborator

@xlauko xlauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo minor nits

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support to this, I added AliasOp to LLVM dialect but didn't get the chance to lower it from CIR! As you noted creating it requires an extra region, just like most versions of LLVM_GlobalOp.

LGTM after some nits

@bcardosolopes bcardosolopes merged commit 504714a into llvm:main Jul 15, 2025
8 of 9 checks passed
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
This updates the lowering of CIR function aliases in such a way that
they now actually become aliases in the final LLVM IR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants