[CIR] Add support for DumpRecordLayouts #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
andykaylor
reviewed
Jun 6, 2025
Collaborator
andykaylor
left a comment
andykaylor
left a comment
There was a problem hiding this comment.
Thanks for implementing this! Can you add a test to verify the output?
| assert(it != BitFields.end() && "Unable to find bitfield info"); | ||
| return it->second; | ||
| } | ||
| void print(raw_ostream &os) const; |
Collaborator
There was a problem hiding this comment.
It's very handy to have an additional method, dump() which prints to llvm::errs() and is marked with LLVM_DUMP_METHOD. This lets you print the object from a debugger.
| os << "<CIRecordLayout\n"; | ||
| os << " CIR Type:" << CompleteObjectType << "\n"; | ||
| if (BaseSubobjectType) | ||
| os << " NonVirtualBaseLLVMType:" << BaseSubobjectType << "\n"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| os << " NonVirtualBaseLLVMType:" << BaseSubobjectType << "\n"; | |
| os << " NonVirtualBaseCIRType:" << BaseSubobjectType << "\n"; |
bcardosolopes
approved these changes
Jun 9, 2025
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
This PR adds support for the `-fdump-record-layouts` flag. It enables printing both the `CIRGenRecordLayout` and the `ASTRecordLayout`, similar to what is done in CodeGen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
-fdump-record-layoutsflag. It enables printing both theCIRGenRecordLayoutand theASTRecordLayout, similar to what is done in CodeGen.