[CIR] Add back LoopOpInterface verification #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a revert of 656151f. It appears that the underlying issues are resolved.
Collaborator
|
This change causes a build failure if static libraries are enabled. Is this related to the circular dependency that @lanza was referring to when this was originally reverted? |
fangyi-zhou
added a commit
to fangyi-zhou/clangir
that referenced
this pull request
May 22, 2025
This reverts commit 0c944f9.
Contributor
Author
|
Sorry about that, I've created a pull request to revert the change. In the meantime, could you tell me how to replicate the build failure? |
Collaborator
I think you should be able to see the problem if you use |
bcardosolopes
pushed a commit
that referenced
this pull request
May 22, 2025
This reverts commit 0c944f9. Reverting due to build failure reported in #1635 (comment)
fangyi-zhou
added a commit
to fangyi-zhou/clangir
that referenced
this pull request
May 23, 2025
lanza
pushed a commit
to lanza/llvm-project
that referenced
this pull request
Aug 11, 2025
…m#1638) This reverts commit 0c944f9. Reverting due to build failure reported in llvm/clangir#1635 (comment)
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit essentially is a revert of 656151f. It appears that the underlying issues are resolved.
Closes #425 and #927