-
Notifications
You must be signed in to change notification settings - Fork 149
[CIR][Lowering] Lower delete array to LLVM #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first contribution and for adding support for this. Few nits and this should be ready to go.
375317b
to
4c97e88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once it passes tests!
@bcardosolopes Sorry about earlier, it seems I didn't ran git-clang-format properly. Hopefully this should be okay now. |
Dispatched another test attempt! |
Initial implementation of lowering cir.delete.array #1285
lowered to a call to _ZdaPv keeping similarity with how Clang AST is lowered.
before
after