Skip to content

[CIR][CIRGen][Builtin][Neon] Lower vabds_f32 and vabdd_f64 #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower vabds_f32 and vabdd_f64 #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/lib/CIR/CodeGen/CIRGenBuiltinAArch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2667,9 +2667,9 @@ static mlir::Value emitCommonNeonSISDBuiltinExpr(
llvm::errs() << getAArch64SIMDIntrinsicString(builtinID) << " ";
llvm_unreachable("in emitCommonNeonSISDBuiltinExpr NYI");
case NEON::BI__builtin_neon_vabdd_f64:
llvm_unreachable(" neon_vabdd_f64 NYI ");
case NEON::BI__builtin_neon_vabds_f32:
llvm_unreachable(" neon_vabds_f32 NYI ");
return emitNeonCall(builder, {argTy}, ops, "aarch64.sisd.fabd", resultTy,
loc);
case NEON::BI__builtin_neon_vabsd_s64:
return emitNeonCall(builder, {argTy}, ops, "aarch64.neon.abs", resultTy,
loc);
Expand Down
32 changes: 20 additions & 12 deletions clang/test/CIR/CodeGen/AArch64/neon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18538,19 +18538,27 @@ int64_t test_vqshlud_n_s64(int64_t a) {
// return vreinterpretq_p64_p16(a);
// }

// NYI-LABEL: @test_vabds_f32(
// NYI: [[VABDS_F32_I:%.*]] = call float @llvm.aarch64.sisd.fabd.f32(float %a, float %b)
// NYI: ret float [[VABDS_F32_I]]
// float32_t test_vabds_f32(float32_t a, float32_t b) {
// return vabds_f32(a, b);
// }
float32_t test_vabds_f32(float32_t a, float32_t b) {
return vabds_f32(a, b);

// NYI-LABEL: @test_vabdd_f64(
// NYI: [[VABDD_F64_I:%.*]] = call double @llvm.aarch64.sisd.fabd.f64(double %a, double %b)
// NYI: ret double [[VABDD_F64_I]]
// float64_t test_vabdd_f64(float64_t a, float64_t b) {
// return vabdd_f64(a, b);
// }
// CIR-LABEL: vabds_f32
// CIR: [[TMP0:%.*]] = cir.llvm.intrinsic "aarch64.sisd.fabd" {{.*}}, {{.*}} : (!cir.float, !cir.float) -> !cir.float

// LLVM-LABEL: @test_vabds_f32(
// LLVM: [[VABDS_F32:%.*]] = call float @llvm.aarch64.sisd.fabd.f32(float %0, float %1)
// LLVM: ret float [[VABDS_F32]]
}

float64_t test_vabdd_f64(float64_t a, float64_t b) {
return vabdd_f64(a, b);

// CIR-LABEL: vabdd_f64
// CIR: [[TMP0:%.*]] = cir.llvm.intrinsic "aarch64.sisd.fabd" {{.*}}, {{.*}} : (!cir.double, !cir.double) -> !cir.double

// LLVM-LABEL: @test_vabdd_f64(
// LLVM: [[VABDD_F64:%.*]] = call double @llvm.aarch64.sisd.fabd.f64(double %0, double %1)
// LLVM: ret double [[VABDD_F64]]
}

// NYI-LABEL: @test_vuqaddq_s8(
// NYI: entry:
Expand Down
Loading