Skip to content

[CIR][CUDA] Treat nvptx triple as alias for nvptx64 #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

[CIR][CUDA] Treat nvptx triple as alias for nvptx64 #1420

merged 5 commits into from
Mar 5, 2025

Conversation

@advay168
Copy link
Contributor

@advay168 advay168 commented Feb 27, 2025

Similar to OG

@advay168
Copy link
Contributor Author

advay168 commented Feb 27, 2025

Also is there any reason CIRGenModule::getTargetCIRGenInfo() is implemented in clang/lib/CIR/CodeGen/TargetInfo.cpp and not clang/lib/CIR/CodeGen/CirGenModule.cpp. Would you be open to a PR for porting it?

bcardosolopes
bcardosolopes requested changes Feb 27, 2025
View reviewed changes
@bcardosolopes
Copy link
Member

bcardosolopes commented Feb 27, 2025

Also is there any reason CIRGenModule::getTargetCIRGenInfo() is implemented in clang/lib/CIR/CodeGen/TargetInfo.cpp and not clang/lib/CIR/CodeGen/CirGenModule.cpp. Would you be open to a PR for porting it?

No good reason, the closer to OG the betters, a PR would be welcome! Thanks

AdUhTkJm
AdUhTkJm reviewed Feb 28, 2025
View reviewed changes
bcardosolopes
bcardosolopes reviewed Mar 1, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needs be a little shorter.

@advay168
Copy link
Contributor Author

advay168 commented Mar 2, 2025

I have shortened the testcase down.

bcardosolopes
bcardosolopes approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending conflict fix!

@bcardosolopes bcardosolopes merged commit d4fbab3 into llvm:main Mar 5, 2025
6 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
@advay168 @lanza
[CIR][CUDA] Treat nvptx triple as alias for nvptx64 (#1420)
d076f0a 
Similar to
[OG](https://github.com/llvm/clangir/blob/8746bd4bbe777352c2935e9937449637a8943767/clang/lib/CodeGen/CodeGenModule.cpp#L219)
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
@advay168 @lanza
[CIR][CUDA] Treat nvptx triple as alias for nvptx64 (llvm#1420)
c402b79 
Similar to
[OG](https://github.com/llvm/clangir/blob/8746bd4bbe777352c2935e9937449637a8943767/clang/lib/CodeGen/CodeGenModule.cpp#L219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

+1 more reviewer

@AdUhTkJm AdUhTkJm AdUhTkJm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@advay168 @bcardosolopes @AdUhTkJm