Skip to content

Conversation

FantasqueX
Copy link
Collaborator

I checked https://github.com/llvm/clangir/blob/main/clang/test/CIR/CodeGen/globals.cpp and thought code works as expected. Although, test results need to be adjusted a bit.

Resolves: #1252

Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@bcardosolopes bcardosolopes merged commit 52bb68c into llvm:main Feb 24, 2025
7 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
I checked
https://github.com/llvm/clangir/blob/main/clang/test/CIR/CodeGen/globals.cpp
and thought code works as expected. Although, test results need to be
adjusted a bit.

Resolves: #1252
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
I checked
https://github.com/llvm/clangir/blob/main/clang/test/CIR/CodeGen/globals.cpp
and thought code works as expected. Although, test results need to be
adjusted a bit.

Resolves: llvm#1252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-XFAIL global-bar-simple test
3 participants