A fix for StaticSVD::ComputeSVD to preserve snapshots #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
requested review from
chldkdtn,
ckendrick,
dylan-copeland and
siuwuncheung
…ration and deletes it after SVD.
Collaborator
Author
|
@chldkdtn @dylan-copeland @ckendrick @siuwuncheung , I made the change per @dylan-copeland 's suggestion and it is ready for review and merge. I made this PR separate from other branches so that this can be merged independently. |
ckendrick
approved these changes
Feb 22, 2024
dylan-copeland
approved these changes
Feb 23, 2024
andersonw1
pushed a commit
that referenced
this pull request
Apr 2, 2024
* StaticSVD::ComputeSVD - copies the sample snapshot matrix for SVD operation and deletes it after SVD. * option for StaticSVD to preserve snapshot. * line break for long message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticSVD::ComputeSVDperforms SVD using scalapack'spdgesvd, which does not preserve the original snapshot matrix. This can be a potential source of error when runningBasisGenerator::getSnapshotMatrixafter SVD operation (BasisGenerator::endSamples()).StaticSVDnow has an option to preserve the snapshot. This option is driven by thebooloptionOptions::static_svd_preserve_snapshot.If snapshot preserving option is false,
StaticSVD::computeSVDuses the originald_samplesas before, modifying the matrix.StaticSVD::getSnapshotMatrixafter svd operation will return an error, so that users would not use the modified snapshot matrix.If snapshot preserving option is true,
StaticSVD::computeSVDcopies fromd_samplesintosnapshot_matrixeither transposed or original, and usesnapshot_matrixas working matrix for SVD operation, preserving the original snapshot matrixd_samples. The working matrixsnapshot_matrixis destroyed at the end of the function call.