Sample mesh manager bug fix #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobLotz
approved these changes
Dec 22, 2023
Collaborator
|
I have verified that this PR fixes issue #242. Thanks @dylan-copeland ! |
Collaborator
Author
|
Thanks @JacobLotz for the review. Sorry I did not see your issue. In the future, assigning me to an issue should help. |
chldkdtn
approved these changes
Jan 2, 2024
ckendrick
approved these changes
Jan 2, 2024
Collaborator
Author
Good point, that some other PRs also have this unused variable that keeps being copied to new examples. Since this PR is already approved, I think other PRs will either have the variable removed when merging with |
andersonw1
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Bug fix. * Cleaning up a few things.
JacobLotz
added a commit
that referenced
this pull request
Feb 19, 2024
andersonw1
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Bug fix. * Cleaning up a few things.
JacobLotz
added a commit
to JacobLotz/libROM-fork
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change in this PR is at line 887 of lib/mfem/SampleMesh.cpp in the master branch. Part of the verification on that line should be done only after the loop over all spaces. This is just a sanity check, and the changes in this PR should have no effect on any results. Other changes in this PR are just to clean up some unused variables, long lines, etc.