Skip to content

Add timing info to DG local advection prom example #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckendrick merged 4 commits into from
Dec 18, 2023
Merged

Add timing info to DG local advection prom example #251

ckendrick merged 4 commits into from
Dec 18, 2023

Conversation

@ckendrick
Copy link
Collaborator

@ckendrick ckendrick commented Nov 20, 2023 •
edited
Loading

This adds a final print statement for the FOM/ROM timings at the end of the DG local advection example prom. A timer for the assemble phase was missing, so that was also added to be consistent with the other examples.

This also fixes an issue when this example is run in parallel with the -online_interp option. This issue can be reproduced by running the following commands.

mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -offline -rs 4 -ff 1.02
mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -interp_prep -rs 4 -ff 1.02 -rdim 40
mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -offline -rs 4 -ff 1.08
mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -interp_prep -rs 4 -ff 1.08 -rdim 40
mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -fom -rs 4 -ff 1.05
mpirun -np 2 ./dg_advection_local_rom_matrix_interp --mesh "../data/periodic-square.mesh" -online_interp -rs 4 -ff 1.05 -rdim 40

@ckendrick ckendrick added the RFR Ready for review label Nov 20, 2023
dylan-copeland
dylan-copeland reviewed Nov 29, 2023
View reviewed changes
@ckendrick ckendrick force-pushed the dg_local_advection_updates branch from 6cb9558 to 73ff70a Compare December 4, 2023 16:22
@dylan-copeland
Copy link
Collaborator

dylan-copeland commented Dec 4, 2023

Line 35 has a pre-existing typo that could be fixed in this PR: lagragian -> lagrangian

andersonw1
andersonw1 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@andersonw1 andersonw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works as described

@ckendrick ckendrick merged commit 27234b3 into master Dec 18, 2023
andersonw1 pushed a commit that referenced this pull request Jan 8, 2024
@ckendrick @andersonw1
Add timing info to DG local advection prom example (#251)
8d1b7d4 
* Add assemble timer and timing prints

* Fix issue with -online_interp when running in parallel

* Update timing print

* Fix minor typo in examples
@ckendrick ckendrick deleted the dg_local_advection_updates branch June 27, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylan-copeland dylan-copeland dylan-copeland approved these changes

@andersonw1 andersonw1 andersonw1 approved these changes

@dreamer2368 dreamer2368 Awaiting requested review from dreamer2368

@siuwuncheung siuwuncheung Awaiting requested review from siuwuncheung

Assignees

No one assigned

Labels

RFR Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ckendrick @dylan-copeland @andersonw1