Bump protocol to v1.37.1 and add audio_features handling #634
Conversation
| UserRejected = 12, | ||
| /// SIP protocol failure or unexpected response | ||
| SipTrunkFailure = 13, | ||
| ConnectionTimeout = 14, |
There was a problem hiding this comment.
Can we simply add this without breaking users' code?
| } | ||
|
|
||
| async fn write(&self, bytes: &[u8]) -> StreamResult<()> { | ||
| async fn write(&self, bytes: &'a [u8]) -> StreamResult<()> { |
There was a problem hiding this comment.
the lifetime annotation here was needed to make it compile locally on my setup (v1.83) - not sure why this wasn't failing on CI, any drawbacks around adding this?
livekit-api/src/services/egress.rs
Outdated
| // TODO implement webhooks | ||
| webhooks: Default::default(), |
There was a problem hiding this comment.
The reason why we have to do this everytime is because we're using the wrong syntax
| // TODO implement webhooks | |
| webhooks: Default::default(), | |
| ..Default::default(), |
|
Is the AudioTrackFeature already done? I don't see it anywhere in the code |
|
Ah, I assumed trackInfo just gets passed as is, but it doesn't. Will add handling for audio track features |
lukasIO
changed the title
lukasIO
changed the title
|
@theomonnom I added handling for audio_features both on the rust side and FFI |
| DisconnectReason::UserUnavailable => Self::UserUnavailable, | ||
| DisconnectReason::UserRejected => Self::UserRejected, | ||
| DisconnectReason::SipTrunkFailure => Self::SipTrunkFailure, | ||
| DisconnectReason::ConnectionTimeout => Self::ConnectionTimeout, |
There was a problem hiding this comment.
Can you create a similar conversion for the TrackFeature?
impl From< AudioTrackFeature > for proto:: AudioTrackFeature {
We're currently only relying on the integer, which is unsafe and will panic as soon as the proto adds a new one
There was a problem hiding this comment.
@theomonnom I added conversions in both directions and added AudioTrackFeature to the rtc prelude
Main motivation is to get the new pre connect buffer AudioTrackFeature added for usage in livekit/agents#2171