Skip to content

fix(rtc): raise error from Rust SDK in participant methods #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rtc): raise error from Rust SDK in participant methods #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions livekit-rtc/livekit/rtc/participant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ def __init__(self, message: str) -> None:
self.message = message


class ParticipantError(Exception):
def __init__(self, message: str) -> None:
self.message = message

class Participant(ABC):
def __init__(self, owned_info: proto_participant.OwnedParticipant) -> None:
self._info = owned_info.info
Expand Down Expand Up @@ -491,9 +495,11 @@ async def set_metadata(self, metadata: str) -> None:
queue = FfiClient.instance.queue.subscribe()
try:
resp = FfiClient.instance.request(req)
await queue.wait_for(
cb: proto_ffi.FfiEvent = await queue.wait_for(
lambda e: e.set_local_metadata.async_id == resp.set_local_metadata.async_id
)
if cb.set_local_metadata.error:
raise ParticipantError(cb.set_local_metadata.error)
finally:
FfiClient.instance.queue.unsubscribe(queue)

Expand All @@ -513,9 +519,12 @@ async def set_name(self, name: str) -> None:
queue = FfiClient.instance.queue.subscribe()
try:
resp = FfiClient.instance.request(req)
await queue.wait_for(
cb: proto_ffi.FfiEvent = await queue.wait_for(
lambda e: e.set_local_name.async_id == resp.set_local_name.async_id
)

if cb.set_local_name.error:
raise ParticipantError(cb.set_local_name.error)
finally:
FfiClient.instance.queue.unsubscribe(queue)

Expand Down Expand Up @@ -543,9 +552,13 @@ async def set_attributes(self, attributes: dict[str, str]) -> None:
queue = FfiClient.instance.queue.subscribe()
try:
resp = FfiClient.instance.request(req)
await queue.wait_for(
cb: proto_ffi.FfiEvent = await queue.wait_for(
lambda e: e.set_local_attributes.async_id == resp.set_local_attributes.async_id
)

if cb.set_local_attributes.error:
raise ParticipantError(cb.set_local_attributes.error)

finally:
FfiClient.instance.queue.unsubscribe(queue)

Expand Down
Loading