Skip to content

Supports getting the connected remote address. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 12, 2022
Merged

Supports getting the connected remote address. #177

merged 6 commits into from
Oct 12, 2022

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Sep 26, 2022 •
edited
Loading

Supports getting the connected remote address for verification migration.

Tested platform.

  • Android
  • macOS
  • Web
  • Windows
  • iOS

@cloudwebrtc
Copy link
Contributor Author

getting :7882 on iOS doesn't seem to get an IP address, is it due to some security mechanism, or is it a bug of the WebRTC SDK on iOS?

image

davidzhao
davidzhao reviewed Sep 27, 2022
View reviewed changes
@davidzhao
Copy link
Member

getting :7882 on iOS doesn't seem to get an IP address, is it due to some security mechanism, or is it a bug of the WebRTC SDK on iOS?

my guess it's a bug. IMO fine to skip the IP check for the purpose of the test.

@cloudwebrtc cloudwebrtc merged commit eaacbf7 into main Oct 12, 2022
@cloudwebrtc cloudwebrtc deleted the duan/support-get-connected-server-address branch October 12, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@hiroshihorie hiroshihorie Awaiting requested review from hiroshihorie

@davidliu davidliu Awaiting requested review from davidliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao