fix: use slice() instead of subarray() to correctly copy VAD audio buffer #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer The previous implementation used `subarray()` which returns a view of the original buffer, causing the copied data to be inadvertently overwritten during subsequent processing. Although a past fix removed the padding from the copied data to mitigate the issue, this made the `prefixPaddingDuration` parameter ineffective. This commit replaces `subarray()` with `slice()` to ensure a proper copy is made, preventing unwanted side effects and restoring correct behavior of prefix padding.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
subarray()which returns a view of the original buffer, causing the copied data to be inadvertently overwritten during subsequent processing.Although a past fix removed the padding from the copied data to mitigate the issue, this made the
prefixPaddingDurationparameter ineffective.This commit replaces
subarray()withslice()to ensure a proper copy is made, preventing unwanted side effects and restoring correct behavior of prefix padding.