-
Notifications
You must be signed in to change notification settings - Fork 1.9k
modern and minimalist UI redesign with new features #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will test it and sleep on it and let you know!! Thank you! |
Looks very nice I like it.. can you put the Google Analytics back please? |
hey @lipis added the Google Analytics back! forgot to include it in the redesign. tracking events are in there too for the format switching (4:3 vs 1:1) like the original had should be good to go now 👍 |
Could you run |
index.html
Outdated
const COUNTRY_CACHE_DURATION = 86400000; // 24 hours in milliseconds | ||
|
||
// Production-ready country detection | ||
const detectUserCountry = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need it? Let's make it simpler.. shall we remove the country detection thingy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a tiny delight the can devs see their own flag in examples :)
also you don't need to worry about crashing it has zero risk: 24hr cache + dual fallback APIs
I think it's a creative addition it makes docs feel personal without complexity I think it's worth keeping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah.. no need to overcomplicate things.. I would rather keep it simple and just show the flags! Usually people using them to show multiple of them anyway.. Thank you! Remove that and we're good to go..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay check it out now I have removed this feature
hey @lipis check it out now I used open-color pallete and formatted using yarn fix |
Awesome!!.. Thanks |
hey @lipis , so i redesigned the site with some cool stuff that was missing before
main changes:
all the styling is done with vanilla CSS no frameworks needed so its super lightweight. did bunch of optimizations for load time too. page was like 2.5s load time before, now its under 1s.
code is structured better (modular functions) and fixed some bugs during implementation like memory leaks from timeouts not being cleared you may review this part if I missed something.
let me know what u think! would be cool to get this merged since it makes the site way more usable especially for devs who just need to grab a flag quick.