refactor(http/prom): decompose record_response middleware
#4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
changed the title
record_response middleware
cratelyn
force-pushed
the
kate/http-prom.add-status-count-middleware
branch
from
5881b73 to
78f506f
Compare
Signed-off-by: katelyn martin <[email protected]>
this commit introduces a new submodule to `linkerd-http-prom`. this submodule includes a `NewRecordStatusCode<N>` middleware that records Prometheus metrics counting response status codes for HTTP and gRPC traffic. Signed-off-by: katelyn martin <[email protected]>
this is akin to #3334, which cleaned up the equivalent expression in `linkerd/app/outbound/src/http/logical/policy/route/metrics.rs`. Signed-off-by: katelyn martin <[email protected]>
before we introduce additional layers to our backend stack, we should define type aliases as prophylaxis against: <https://rust-lang.github.io/rust-clippy/stable/index.html#type_complexity> Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/http-prom.add-status-count-middleware
branch
from
78f506f to
d63b598
Compare
Member
Author
|
decomposing this into separate pull requests. see #4298. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(http/prom): add
linkerd-http-body-eosdependencySigned-off-by: katelyn martin [email protected]
feat(http/prom): add
statusmiddlewarethis commit introduces a new submodule to
linkerd-http-prom.this submodule includes a
NewRecordStatusCode<N>middleware thatrecords Prometheus metrics counting response status codes for HTTP and
gRPC traffic.
Signed-off-by: katelyn martin [email protected]
refactor(app/outbound): simplify backend layer construction
this is akin to feat(app): Route frame count metrics #3334, which cleaned up the equivalent expression in
linkerd/app/outbound/src/http/logical/policy/route/metrics.rs.Signed-off-by: katelyn martin [email protected]
refactor(app/outbound): type aliases in backend metrics layer
before we introduce additional layers to our backend stack, we should
define type aliases as prophylaxis against:
https://rust-lang.github.io/rust-clippy/stable/index.html#type_complexity
Signed-off-by: katelyn martin [email protected]
feat(app/outbound): add status counters to route metrics
Signed-off-by: katelyn martin [email protected]
feat(app/outbound): add status counters to backend metrics
Signed-off-by: katelyn martin [email protected]
feat(app/outbound): add route status counting middleware
Signed-off-by: katelyn martin [email protected]
feat(app/outbound): add backend status counting middleware
Signed-off-by: katelyn martin [email protected]
refactor(app/outbound): remove status counter from duration middleware
Signed-off-by: katelyn martin [email protected]