Change 'postback.params' type from python object to dict. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdtsk
approved these changes
Sep 8, 2017
Member
okdtsk
left a comment
okdtsk
left a comment
There was a problem hiding this comment.
LGTM!
Ref)
line-bot-sdk-java also has a pull request to change postback.params implementation from Object to Map<String, String>.
Renari
pushed a commit
to Renari/line-bot-sdk-python
that referenced
this pull request
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility that new values will be added to
postback.paramfrom now on.To support flexibly, use
dictinstead of dedicated objects.