Skip to content

Add Get Group/Room Member Profile API #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
be-hase merged 4 commits into from
Aug 28, 2017
Merged

Add Get Group/Room Member Profile API #53

be-hase merged 4 commits into from
Aug 28, 2017

Conversation

@turfaa
Copy link
Contributor

@turfaa turfaa commented Aug 8, 2017

Add the Get Group/Room Member Profile API as stated at https://devdocs.line.me/en/#get-group-room-member-profile.

be-hase
be-hase requested changes Aug 15, 2017
View reviewed changes
README.rst Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Gets the user profile of a member of a group that
the bot is in. This can be the user ID of a user who has
Copy link
Member

@be-hase be-hase Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove unneeded space ?
It seems that rendering is failed.

2017-08-15 13 26 42

Copy link
Contributor Author

@turfaa turfaa Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.rst Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Gets the user profile of a member of a room that
the bot is in. This can be the user ID of a user who has
Copy link
Member

@be-hase be-hase Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

@turfaa turfaa Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@be-hase
Copy link
Member

be-hase commented Aug 15, 2017

Thanks for your PR.
BTW, did you already sign ICLA? If not, please sign from here.
https://feedback.line.me/enquete/public/919-h9Yqmr1u

@turfaa
Copy link
Contributor Author

turfaa commented Aug 19, 2017

@be-hase yes i've signed the ICLA.

@be-hase
Copy link
Member

be-hase commented Aug 28, 2017

@be-hase yes i've signed the ICLA.

thanks !
i will release soon.

@be-hase be-hase merged commit 0e1ecf2 into line:master Aug 28, 2017
@tokuhirom tokuhirom mentioned this pull request Sep 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@be-hase be-hase be-hase requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turfaa @be-hase