Skip to content

Flex Message Update 1 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
okue merged 8 commits into from
Sep 4, 2019
Merged

Flex Message Update 1 #205

okue merged 8 commits into from
Sep 4, 2019

Conversation

@okue
Copy link
Member

@okue okue commented Aug 28, 2019 •
edited
Loading

#204

  • add new fields for Flex message
  • add tests
  • add an example using a new spec of Flex message

@okue okue self-assigned this Aug 28, 2019
@okue okue added the WIP label Aug 28, 2019
@okue okue removed the WIP label Aug 28, 2019
@okue okue requested a review from be-hase August 28, 2019 23:21
@tkgauri tkgauri requested a review from cryeo August 29, 2019 05:42
tkgauri
tkgauri reviewed Aug 29, 2019
View reviewed changes
cryeo
cryeo reviewed Sep 1, 2019
View reviewed changes
cryeo
cryeo reviewed Sep 1, 2019
View reviewed changes
cryeo
cryeo approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@cryeo cryeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okue okue mentioned this pull request Sep 4, 2019
Closed
@okue okue merged commit 85b43ac into master Sep 4, 2019
@okue okue deleted the flex_1_update branch September 4, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@be-hase be-hase Awaiting requested review from be-hase

2 more reviewers

@tkgauri tkgauri tkgauri left review comments

@cryeo cryeo cryeo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@okue okue

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@okue @cryeo @tkgauri