refactor: pass context.TODO() by parameter

[zyfy29]

close #3874

[Copilot]

Pull Request Overview

This PR refactors the codebase to improve context management by passing context.Context as a parameter instead of using context.TODO() locally within functions. This addresses issue #3874 and follows Go best practices for context propagation.

• Updates function signatures to accept context.Context as the first parameter
• Removes local context.TODO() calls and imports where no longer needed
• Preserves existing functionality by passing context.TODO() at call sites where context is not available

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/windows/process_windows.go	Updated GetProcessCommandLine to accept context parameter
pkg/sysprof/sysprof_darwin.go	Updated SystemProfiler to accept context parameter
pkg/store/instance_windows.go	Updated GetSSHAddress to accept context parameter
pkg/sshutil/sshutil_test.go	Updated test to pass context.TODO() to DefaultPubKeys
pkg/sshutil/sshutil.go	Updated multiple functions to accept context parameter
pkg/qemuimgutil/qemuimgutil.go	Updated utility functions to accept context parameter
pkg/osutil/user.go	Updated call function to accept context parameter
pkg/osutil/osutil_unix.go	Updated Sysctl to accept context parameter
pkg/osutil/machineid.go	Updated machineID to accept context parameter
pkg/networks/sudoers.go	Updated passwordLessSudo to accept context parameter
pkg/networks/reconcile/reconcile.go	Updated sudo function to accept context parameter
pkg/limayaml/defaults_test.go	Updated test calls to pass context.TODO()
pkg/limayaml/defaults.go	Updated WindowsSubsystemPath call to pass context.TODO()
pkg/ioutilx/ioutilx.go	Updated path conversion functions to accept context parameter
pkg/hostagent/mount.go	Updated WindowsSubsystemPath call to pass context.TODO()
pkg/hostagent/dns/dns.go	Updated handleQuery to accept context parameter
pkg/guestagent/iptables/iptables.go	Updated checkPortsOpen to accept context parameter
pkg/editutil/editutil.go	Updated OpenEditor to accept context parameter
pkg/driver/vz/vm_darwin.go	Updated DialQemu calls to pass context.TODO()
pkg/driver/vz/network_darwin_test.go	Updated test to pass context.TODO() to DialQemu
pkg/driver/vz/network_darwin.go	Updated DialQemu to accept context parameter
pkg/driver/qemu/qemu_driver.go	Updated FindVirtiofsd call to pass context.TODO()
pkg/driver/qemu/qemu.go	Updated multiple utility functions to accept context parameter
pkg/driver/qemu/entitlementutil/entitlementutil.go	Updated signing functions to accept context parameter
pkg/driver/external/server/server.go	Updated Serve to accept context parameter
pkg/cidata/cidata.go	Updated DefaultPubKeys call to pass context.TODO()
pkg/autostart/autostart.go	Updated enableDisableService to accept context parameter
cmd/limactl/shell.go	Updated path conversion calls to pass context.TODO()
cmd/limactl/edit.go	Updated OpenEditor call to pass context.TODO()
cmd/limactl/copy.go	Updated WindowsSubsystemPath call to pass context.TODO()
cmd/lima-driver-wsl2/main_windows.go	Updated Serve call to pass context.TODO()
cmd/lima-driver-vz/main_darwin.go	Updated Serve call to pass context.TODO()
cmd/lima-driver-qemu/main.go	Updated Serve call to pass context.TODO()

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[AkihiroSuda]

Suggested change

	yBytes, err = editutil.OpenEditor(context.TODO(), yContent, hdr)
	yBytes, err = editutil.OpenEditor(ctx, yContent, hdr)

w/ ctx := cmd.Context()

[AkihiroSuda]

Thanks, but this doesn't follow what I meant in #3874

[zyfy29]

Oh, I understand what your mean. The ctx should be passed over from the deamon or command context, is it right? I will update my work later.

[zyfy29]

Windows tests QEMU successed at the last time, maybe we can try it again.

[AkihiroSuda]

Please squash the commits
https://lima-vm.io/docs/dev/git/#squashing-commits

[AkihiroSuda]

Thanks