build: update dependencies to prevent unnecessary bitcoind ZMQ timeouts #3284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
requested review from
cfromknecht,
halseth,
joostjager and
Roasbeef
as code owners
|
Can be updated to the latest |
|
It already is. |
|
Looks like btcsuite/btcwallet#633 was merged after. |
* We address an issue where we would unnecessarily time out bitcoind ZMQ connections if there are no messages to be read. This would cause connections to be torn down, which would then trigger the reconnection logic and prevent us from detecting this issue. * A new sanity check within the wallet is done to prevent adding unconfirmed transactions that the wallet has already recognized as confirmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We address an issue where we would unnecessarily time out bitcoind ZMQ connections if there are no messages to be read. This would cause connections to be torn down, which would then trigger the reconnection logic and prevent us from detecting this issue.
A new sanity check within the wallet is done to prevent adding unconfirmed transactions that the wallet has already recognized as confirmed.