Skip to content

Conversation

@Roasbeef
Copy link
Member

Tried to make this one very comprehensive, but it can likely be split up into smaller docs.

@Roasbeef Roasbeef added documentation Improvements or additions to documentation no-changelog labels Sep 10, 2025
@coveralls
Copy link

coveralls commented Sep 10, 2025

Pull Request Test Coverage Report for Build 18142751393

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6275 unchanged lines in 71 files lost coverage.
  • Overall coverage decreased (-0.5%) to 56.483%

Files with Coverage Reduction New Missed Lines %
commitment/tap.go 1 85.65%
fn/context_guard.go 1 91.94%
universe/supplyverifier/env.go 1 87.5%
asset/asset.go 2 80.3%
mssmt/node.go 2 98.76%
mssmt/proof.go 2 97.59%
tapdb/sqlc/transfers.sql.go 2 83.33%
tapgarden/custodian.go 2 77.02%
taprpc/taprootassets_grpc.pb.go 2 60.33%
universe_rpc_diff.go 2 76.0%
Totals Coverage Status
Change from base Build 17562325369: -0.5%
Covered Lines: 63674
Relevant Lines: 112731

💛 - Coveralls

@Roasbeef Roasbeef requested review from ffranr and jtobin September 17, 2025 00:07
A stylistic tagline had been appended to several section titles, which
felt out of place to me. This commit removes all such taglines, and also
renames the 'The Architecture of Precision' section to 'The FixedPoint
Type' (which is what it primarily deals with).
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is very (too) long, but it can be split up in a separate effort. The content LGTM, though see my PR to your branch for minor stylistic suggestions.

@lightninglabs-deploy
Copy link

@ffranr: review reminder

docs: fix up section titles in rfq arch doc
@Roasbeef Roasbeef merged commit 614acdc into lightninglabs:main Sep 30, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants