loopdb: add deposit indices

[hieblmi]

Add db indices for deposits and deposit updates.

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving database performance by introducing new indices to the deposits and deposit_updates tables within the loopdb schema. These additions are designed to optimize query execution times for operations involving these tables, particularly when filtering or sorting by deposit_id and update_timestamp.

Highlights

• Database Indexing: Two new indices have been added to the database schema. The first, deposits_id_index, is created on the deposits table for the deposit_id column. The second, deposit_updates_id_timestamp_index, is created on the deposit_updates table for the deposit_id and update_timestamp columns, with the update_timestamp ordered in descending order.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds two database indices to improve performance for deposit-related queries. The index on deposit_updates(deposit_id, update_timestamp DESC) is a great addition that will significantly speed up fetching the latest update for a deposit. However, the index on deposits(deposit_id) is redundant, as an index is already created by the UNIQUE constraint on that column. I've added a comment with details.

[starius]

This code won't be executed by existing Loop clients, since it is an old migration. I propose to make new migration to add this index. And also add a corresponding code to a .down.sql file.

Could you add a new line, please? GitHub shows that it is missing in the end of the file.

[bhandras]

+1

[hieblmi]

apologies, fixed!