Add listinstantouts command
#708
Conversation
hieblmi
left a comment
hieblmi
left a comment
There was a problem hiding this comment.
Was thinking that we could provide getter methods for the exposed fields rather than making them public.
| initiationHeight: initCtx.initationHeight, | ||
| outgoingChanSet: initCtx.outgoingChanSet, | ||
| cltvExpiry: initCtx.cltvExpiry, | ||
| CltvExpiry: initCtx.cltvExpiry, |
There was a problem hiding this comment.
Alternatively, to not open up the scope, we could just provide getters for these members. That would also reduce the diff.
There was a problem hiding this comment.
I'd tend to agree, but given that the added use-case doesn't involve sharing state as all instantouts are fetched from the DB, we can keep the exported members too.
|
sputn1ck
force-pushed
the
listinstantouts
branch
from
0f756dd to
982dcb6
Compare
sputn1ck
force-pushed
the
listinstantouts
branch
from
982dcb6 to
034bc24
Compare
| initiationHeight: initCtx.initationHeight, | ||
| outgoingChanSet: initCtx.outgoingChanSet, | ||
| cltvExpiry: initCtx.cltvExpiry, | ||
| CltvExpiry: initCtx.cltvExpiry, |
There was a problem hiding this comment.
I'd tend to agree, but given that the added use-case doesn't involve sharing state as all instantouts are fetched from the DB, we can keep the exported members too.
3 participants
This PR adds the
listinstantoutscli command which let's users monitor their instant out swaps.