loopdb: fix faulty timestamps on startup #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
force-pushed
the
fix_faulty_timestamps
branch
3 times, most recently
from
5b161ae to
3664ec9
Compare
This commit fixes faulty timestamps caused by using unix milliseconds as unix seconds on startup. This commit also adds a test for the lightning-terminal issue that first reported the bug.
sputn1ck
force-pushed
the
fix_faulty_timestamps
branch
from
f2954b8 to
a8578e8
Compare
bhandras
approved these changes
Aug 7, 2023
Member
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
LGTM, great work on this fix! 💯
GeorgeTsagk
approved these changes
Aug 7, 2023
hieblmi
reviewed
Aug 8, 2023
hieblmi
reviewed
Aug 8, 2023
sputn1ck
force-pushed
the
fix_faulty_timestamps
branch
from
a8578e8 to
4cec239
Compare
sputn1ck
force-pushed
the
fix_faulty_timestamps
branch
from
4cec239 to
be9ca71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses lightninglabs/lightning-terminal#615 .
For now I only fix the faulty timestamps on startup. We need to discuss whether loop should check if the timestamp is in milliseconds (and use seconds instead) or if we want to change how lightning-terminal constructs the loop out swap.