itest improvements (docs references and vscode examples) #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the mode of itest configuration in `launch.json` to test-mode. It also removes the unused flag `btcdexec`. The binary is expected by lnd though, so it still needs to be built.
ZZiigguurraatt
force-pushed
the
general_itest_improvements
branch
from
9c464a2 to
bb21c3c
Compare
ZZiigguurraatt
changed the title
|
@gijswijs, would appreciate if you could take a look and compare to ZZiigguurraatt#1. github is not allowing me to add you as a reviewer for some reason. |
|
Does it make sense to use Or, maybe the |
ZZiigguurraatt
changed the title
ZZiigguurraatt
force-pushed
the
general_itest_improvements
branch
from
b408d20 to
c0e0097
Compare
|
@gijswijs: review reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked changes from #898 . Also working to add some documentation and other improvements
.vscodeto.vscode-samples