Skip to content

accounts: Credit and debit accounts kvdb additions prep #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ViktorTigerstrom
Copy link
Contributor

Part of #648

This PR adds DB preparation required for the KVDB store, in order to support functionality which allows crediting or debiting an account's balance by a given amount.

In preparation for the upcoming credit/debit accounts feature, rename
the store `IncreaseAccountBalance` method to `CreditAccount` to better
reflect its purpose.
@ViktorTigerstrom ViktorTigerstrom added the no-changelog This PR is does not require a release notes entry label Feb 18, 2025
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🙏

This commit introduces the `DebitAccount` function in the kvdb store,
to support decreasing an existing off-chain account’s balance by a
specified amount in the database.
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2025-02-credit-debit-accounts-kvdb-prep branch from ab0a78d to 3d67a7e Compare February 18, 2025 11:20
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@ellemouton ellemouton merged commit 400a129 into lightninglabs:master Feb 20, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR is does not require a release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants