Skip to content

Update faraday to v0.2.14-alpha #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update faraday to v0.2.14-alpha #952

merged 2 commits into from
Jan 23, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Jan 23, 2025

Bumps faraday to the latest version and adds the version info for litd v0.14.1-alpha to the README (which was both forgotten in #950).

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the faraday bump!

Regarding the second point:

adds the version info for litd v0.14.1-alpha to the README (which was both forgotten in #950).

I thought that was intentionally left out in the previous PR, as this is only an RC release, but this goes into the master branch README. If we want to include it, should we at least mention that those versions are for the RC version?

@guggero
Copy link
Member Author

guggero commented Jan 23, 2025

If we want to include it, should we at least mention that those versions are for the RC version?

Hmm, yeah, good point. It's the first time we do an RC from the master branch, so not sure what the procedure should look like.
IMO we have two options:

  • Don't update the README for RCs, only for final releases
  • Update the README for RCs but mention the .rcX suffix specifically, then for the final release remove the suffix

What do y'all prefer, cc @ellemouton?

@ViktorTigerstrom
Copy link
Contributor

ViktorTigerstrom commented Jan 23, 2025

I'm ok with both options, but with a slight lean towards:

Don't update the README for RCs, only for final releases

But I don't have a strong opinion, so if you both prefer to add it to the README with the RC suffix, I'd be ok with that as well.

@guggero guggero requested a review from ellemouton January 23, 2025 09:52
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah either one of those options sounds good to me. Perhaps more info is better, and ie, let's include the -rc in the README just so that it is up to date for folks running the rc tag.

@guggero
Copy link
Member Author

guggero commented Jan 23, 2025

Hmm, two different preferences, so I decided to go with the one easiest to implement (e.g. add the .rc1 suffix to the README).

@guggero guggero merged commit 09c1c16 into master Jan 23, 2025
15 of 16 checks passed
@guggero guggero deleted the dep-update branch January 23, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants