-
Notifications
You must be signed in to change notification settings - Fork 103
Update faraday to v0.2.14-alpha #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on the faraday bump!
Regarding the second point:
adds the version info for litd v0.14.1-alpha to the README (which was both forgotten in #950).
I thought that was intentionally left out in the previous PR, as this is only an RC release, but this goes into the master branch README. If we want to include it, should we at least mention that those versions are for the RC version?
Hmm, yeah, good point. It's the first time we do an RC from the
What do y'all prefer, cc @ellemouton? |
I'm ok with both options, but with a slight lean towards:
But I don't have a strong opinion, so if you both prefer to add it to the README with the RC suffix, I'd be ok with that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah either one of those options sounds good to me. Perhaps more info is better, and ie, let's include the -rc
in the README just so that it is up to date for folks running the rc tag.
Hmm, two different preferences, so I decided to go with the one easiest to implement (e.g. add the |
Bumps
faraday
to the latest version and adds the version info forlitd v0.14.1-alpha
to the README (which was both forgotten in #950).