[sql-24] firewalldb: thread contexts through for privacy mapper interfaces #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
sql24
branch
6 times, most recently
from
4b0986c to
8239e03
Compare
ellemouton
added
the
no-changelog
ellemouton
force-pushed
the
sql24
branch
2 times, most recently
from
b60a5c6 to
e4cf3f5
Compare
bitromortac
reviewed
Mar 24, 2025
Update the PrivacyMapDB interface methods to take contexts (both the methods themselves and the call-back params) and then ensure all implementations are updated and all call-sites pass contexts through correctly.
Update the NewPair method of the PrivacyMapTx interface to take a context.
Update the PseudoToReal method of the PrivacyMapTx interface to take a context.
Update the RealToPseudo method of the PrivacyMapTx interface to take a context.
Update the FetchAllPairs method of the PrivacyMapTx interface to take a context.
In this commit, we delete the PrivacyMapDB interface definition and instead use the generic DBExecutor interface parameterised by a PrivacyMapTx to define the PrivacyMapDB interface.
The `kvStores` and `privacyMapDB` types have very similar looking `Update` and `View` methods. Instead of the duplication, here we let things be more generic by defining a generic `kvdbExecutor` which has Update and View methods defined.
ViktorTigerstrom
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we do a a few things: