zmq: prevent unnecessary timeouts and return EOF on connection termination #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2019
We'll only set read deadlines on the underlying connection when reading messages of multiple frames after the first frame has been read. This is done to ensure we receive all of the frames of a message within a reasonable time frame. When reading the first frame, we want to avoid setting them as we don't know when a new message will be available for us to read, causing us to block until its delivery.
If the connection is explicitly terminated, we should not try to re-establish the connection since doing so signals that the connection is no longer needed.
halseth
reviewed
Jul 10, 2019
| @@ -0,0 +1,3 @@ | |||
| module github.com/lightninglabs/gozmq | |||
|
|
|||
| go 1.12 | |||
There was a problem hiding this comment.
Roasbeef
requested changes
Jul 10, 2019
| if err != nil { | ||
| // Prevent CPU overuse by refused reconnection attempts. | ||
| time.Sleep(c.timeout) | ||
| } else { | ||
| c.Close() | ||
| *c = *newConn | ||
| c.conn.Close() |
There was a problem hiding this comment.
We still want to return errTimeout. Closing this connection seems like more of a best effort thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we address an issue where it's possible for us to time out connections when there aren't any messages to read. To address this, we'll only set read deadlines on the underlying connection when reading messages of multiple frames after the first frame has been read. This is done to ensure we receive all of the frames of a message within a reasonable time frame. When reading the first frame, we want to avoid setting them as we don't know when a new message will be available for us to read, causing us to block until its delivery. As a result, a separate issue was discovered where connections would attempt to be re-established even when the user of the connection had explicitly terminated it.