Fix media module tests by implementing missing resizeToRatio function #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The media module tests were failing because the resizeToRatio extension function was being called on line 131 of MediaPreviewOptions.kt but was never implemented. This function is needed to crop images to match a target aspect ratio. Changes: - Implemented ImmutableImage.resizeToRatio() extension function that crops images from the center to achieve the target aspect ratio - Added import for kotlin.math.min - Updated TODO comments to remove completed validation items The implementation: - Returns the original image if targetRatio is null or already matches - Crops width when image is too wide for the target ratio - Crops height when image is too tall for the target ratio - Uses center cropping to maintain the most important image content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The media module tests were failing because the resizeToRatio extension function was being called on line 131 of MediaPreviewOptions.kt but was never implemented. This function is needed to crop images to match a target aspect ratio.
Changes:
The implementation: