Call peer_manager.process_events() in BackgroundProcessor #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 90.59% 90.62% +0.03%
==========================================
Files 51 51
Lines 27195 27200 +5
==========================================
+ Hits 24638 24651 +13
+ Misses 2557 2549 -8
Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Apr 5, 2021
| { | ||
| let stop_thread = Arc::new(AtomicBool::new(false)); | ||
| let stop_thread_clone = stop_thread.clone(); | ||
| let handle = thread::spawn(move || -> Result<(), std::io::Error> { | ||
| let mut current_time = Instant::now(); | ||
| loop { | ||
| let updates_available = manager.await_persistable_update_timeout(Duration::from_millis(100)); | ||
| peer_manager.process_events(); |
There was a problem hiding this comment.
Hmm, unrelated to this PR, but we really need to fix support for knowing we need to persist if something happened while we weren't awaiting. Probably some unique id that just gets incremented every time we would wake up any waiters and then get that as a part of the write process. Then we can always check that the ID is the latest.
jkczyz
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense for RL to handle this on behalf of the user if possible, and
BackgroundProcessorseems to be a sane place to put it.