Skip to content

Channel Manager Persist-Required Checker #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Apr 5, 2021 · 1 comment
Closed

Channel Manager Persist-Required Checker #865

TheBlueMatt opened this issue Apr 5, 2021 · 1 comment

Comments

@TheBlueMatt
Copy link
Collaborator

We need to improve the await_persistable_update API in ChannelManager with at least a few things -

  • It should be possible to detect when if a new update has come in while we were'nt awaiting - eg the comment here notes the obvious pattern used actually may miss persistence events - Call peer_manager.process_events() in BackgroundProcessor #864 (comment)
  • We should avoid generating persistence events for events that obviously don't need it - eg we had a user complain about duplicate block/transaction connection events generating persistence, but some other candidates include timer_chan_freshness_every_min (if it didn't do anything).
@TheBlueMatt
Copy link
Collaborator Author

I believe this is largely addressed. If we have any more cases of excess updates we can open new issues for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant