Skip to content

Make util::logger::macro_logger pub(crate) not pub. #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

There is no reason for it to be pub, its a largely-internal
implementation detail of how we format our own objects for logging.

There is no reason for it to be pub, its a largely-internal
implementation detail of how we format our own objects for logging.
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #834 (f18b6b0) into main (8b4ea56) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   90.97%   90.98%           
=======================================
  Files          48       48           
  Lines       26538    26538           
=======================================
+ Hits        24144    24146    +2     
+ Misses       2394     2392    -2     
Impacted Files Coverage Δ
lightning/src/ln/functional_tests.rs 96.91% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4ea56...9b55c03. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit c9321c5 into lightningdevkit:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants