Make util::logger::macro_logger pub(crate) not pub.
#834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason for it to be pub, its a largely-internal implementation detail of how we format our own objects for logging.
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 90.97% 90.98%
=======================================
Files 48 48
Lines 26538 26538
=======================================
+ Hits 24144 24146 +2
+ Misses 2394 2392 -2
Continue to review full report at Codecov.
|
arik-so
approved these changes
Mar 10, 2021
valentinewallace
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason for it to be pub, its a largely-internal
implementation detail of how we format our own objects for logging.