Skip to content

Adds Copy to ChannelHandshakeConfig and UserConfig #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

sr-gi
Copy link
Contributor

@sr-gi sr-gi commented Jan 5, 2021

Adds Copy to ChannelHandshakeConfig and UserConfig for consistency with the rest of config structs.

This commits adds Copy to ChannelHandshakeConfig and UserConfig for consistency with the rest of config structs.
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #769 (ee51de9) into main (9c9c881) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
- Coverage   91.29%   91.26%   -0.04%     
==========================================
  Files          37       37              
  Lines       22791    22791              
==========================================
- Hits        20808    20800       -8     
- Misses       1983     1991       +8     
Impacted Files Coverage Δ
lightning/src/util/config.rs 50.00% <50.00%> (-19.05%) ⬇️
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9c881...ee51de9. Read the comment docs.

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK ee51de9.

@TheBlueMatt TheBlueMatt merged commit aa9ecab into lightningdevkit:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants