Split NetworkGraph message handling fns into unsigned and signed (+update bindings)
#758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems travis isn't even bothering to spawn our jobs anymore, and Github CI has been pretty stable, so just drop Travis entirely.
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 37 37
Lines 22411 22423 +12
=======================================
+ Hits 20486 20497 +11
- Misses 1925 1926 +1
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2020-11-bindings-fix
branch
from
2ec7475 to
b80a74b
Compare
This makes the public utility methods in `NetworkGraph` able to do UTXO lookups ala `NetworkMsgHandler`'s `RoutingMessageHandler` implementation, slightly simplifying the public interface. We also take this opportunity to verify signatures before calling out to UTXO lookups, under the "do actions in order of cheapest-to-most-expensive to reduce DoS surface" principle.
TheBlueMatt
force-pushed
the
2020-11-bindings-fix
branch
2 times, most recently
from
932d3ac to
083c02a
Compare
jkczyz
approved these changes
Nov 24, 2020
valentinewallace
approved these changes
Nov 24, 2020
This takes the now-public `NetworkGraph` message handling functions and splits them all into two methods - one which takes a required Secp256k1 context and verifies signatures and one which takes only the unsigned part of the message and does not take a Secp256k1 context. This both clarifies the public API as well as simplifies it, all without duplicating code. Finally, this adds an assertion in the Router fuzzer to make sure the constants used for message deserialization are correct.
TheBlueMatt
force-pushed
the
2020-11-bindings-fix
branch
from
083c02a to
1447729
Compare
|
Only changed the minor nits from @jkczyz. |
TheBlueMatt
force-pushed
the
2020-11-bindings-fix
branch
from
1447729 to
ccd4a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Val noted in 748 (#748 (comment)) that exposing the existing functions as public was a bit lazy. I indicated I'd handle it in a follow-up post-0.0.12, but realized that 0.0.12 didn't actually pass bindings checks because the newly-exposed APIs required additional features in the bindings. Thus, I went ahead and did the fixup here as well as updated the auto-generated bindings successfully.
As a bonus, this drops Travis CI.