Skip to content

Conversation

TheBlueMatt
Copy link
Collaborator

A few trivial cleanups, most of them to address new rustc warnings.

1107ab0 added a Vec of future
updates to apply during a loop, fixing a borrow checker issue that
didn't exist in the merged version of the patch. This simply reverts
that small part of the change.
It appears to be effectively-deprecated in Rust now, and didn't
really appear to serve a lot of purpose anyway.
@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b9db2ec). Click here to learn what that means.
The diff coverage is n/a.

@TheBlueMatt
Copy link
Collaborator Author

After we moved the ChannelMonitor creation later during Channel
init, we never went back and cleaned up ChannelMonitor to remove
a number of now-useless Option<>s, so we do that now.
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup!

@TheBlueMatt TheBlueMatt merged commit 5a2ed03 into lightningdevkit:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants