Skip to content

multi: update ChannelManager's keys manager from Arc to Deref #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

multi: update ChannelManager's keys manager from Arc to Deref #518

merged 1 commit into from
Feb 27, 2020

Conversation

valentinewallace
Copy link
Contributor

Partially addresses #237.

ariard
ariard approved these changes Feb 26, 2020
View reviewed changes
Copy link

@ariard ariard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3e30c34

TheBlueMatt
TheBlueMatt reviewed Feb 27, 2020
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mod small comments, also needs rebase, sorry about that.

@valentinewallace valentinewallace force-pushed the chanmgr-keysmgr-arc-to-deref branch from 3e30c34 to bff9982 Compare February 27, 2020 16:55
@TheBlueMatt TheBlueMatt merged commit f328094 into lightningdevkit:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

@ariard ariard ariard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinewallace @TheBlueMatt @ariard