-
Notifications
You must be signed in to change notification settings - Fork 406
Investigate dropping Arcs for references #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oops. We've made great progress here, but there's still a bunch of required Arcs. |
maybe rename to |
I think we also need a few ChainWatchInterfaces to not be Arcs - at least in Router and SimpleManyChannelMonitor, PeerHandler's Routing and ChannelMessageHandlers should not be Arcs (though I presume that may happen via @arik-so's ongoing work) as well. |
I realized I'm still assigned to this. @TheBlueMatt are there still TODOs for this issue? |
Hmm, no, likely not. There was some previous discussion to maybe swap the Derefs for |
We should see if we can take advantage of the borrow checker to drop a bunch of Arcs and hold references in a number of places, may require #80, though. Should also look into nice things like dropping the secp_ctx in Channels and holding a reference to the ChannelManager one, too.
The text was updated successfully, but these errors were encountered: