Skip to content

Investigate dropping Arcs for references #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Nov 1, 2018 · 5 comments · Fixed by #443
Closed

Investigate dropping Arcs for references #237

TheBlueMatt opened this issue Nov 1, 2018 · 5 comments · Fixed by #443
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

We should see if we can take advantage of the borrow checker to drop a bunch of Arcs and hold references in a number of places, may require #80, though. Should also look into nice things like dropping the secp_ctx in Channels and holding a reference to the ChannelManager one, too.

@TheBlueMatt
Copy link
Collaborator Author

Oops. We've made great progress here, but there's still a bunch of required Arcs.

@valentinewallace
Copy link
Contributor

maybe rename to Update ChannelManager's Logger from Arc to Deref? or close + new issue?

@TheBlueMatt
Copy link
Collaborator Author

I think we also need a few ChainWatchInterfaces to not be Arcs - at least in Router and SimpleManyChannelMonitor, PeerHandler's Routing and ChannelMessageHandlers should not be Arcs (though I presume that may happen via @arik-so's ongoing work) as well.

@valentinewallace
Copy link
Contributor

I realized I'm still assigned to this. @TheBlueMatt are there still TODOs for this issue?

@TheBlueMatt
Copy link
Collaborator Author

Hmm, no, likely not. There was some previous discussion to maybe swap the Derefs for impl Trait for Deref<Target=Trait> instead, or maybe BorrowMTarget=Trait>, but that's separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants