Fix bumping timer for claiming revoked HTLC outputs #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using their_to_self_delay instead of our_to_self_delay which was falsifying test.
TheBlueMatt
approved these changes
Jan 25, 2020
|
Sadly it was tested by test_bump_penalty_txn_on_revoked_htlcs, but the test being fairly complex I didn't notice it at first, between wrong and good heights.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using their_to_self_delay instead of
our_to_self_delay which was falsifying test.
Another bug I spot while refactoring, can go on its own.
We should rename their_to_self/our_to_self to csv_on_remote, csv_on_local that would be more meaningful.