Skip to content

Include monitor name in error when failing to load a monitor #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

Include monitor name in error when failing to load a monitor #4192

merged 1 commit into from
Oct 30, 2025

Conversation

@TheBlueMatt
Copy link
Collaborator

@TheBlueMatt TheBlueMatt commented Oct 30, 2025

If we fail to load a ChannelMonitor due to the new limits in LDK 0.2, its useful to communicate which monitor failed, which we do here.

Requested at
#4146 (comment)

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025 •
edited
Loading

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@valentinewallace
Copy link
Contributor

valentinewallace commented Oct 30, 2025

Oh, rustfmt CI is sad

@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.86%. Comparing base (2849ae2) to head (a4f4663).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/persist.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4192      +/-   ##
==========================================
- Coverage   88.87%   88.86%   -0.01%     
==========================================
  Files         180      180              
  Lines      137876   137879       +3     
  Branches   137876   137879       +3     
==========================================
- Hits       122532   122531       -1     
+ Misses      12543    12542       -1     
- Partials     2801     2806       +5
Flag Coverage Δ
fuzzing 21.43% <0.00%> (-0.01%) ⬇️
tests 88.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt
Include monitor name in error when failing to load a monitor
a4f4663 
If we fail to load a `ChannelMonitor` due to the new limits in LDK
0.2, its useful to communicate which monitor failed, which we do
here.

Requested at
lightningdevkit#4146 (comment)
@TheBlueMatt TheBlueMatt force-pushed the 2025-10-mon-err-print branch from 52b42cd to a4f4663 Compare October 30, 2025 17:49
@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Oct 30, 2025

Grr, I ran it locally and it didn't complain.

@TheBlueMatt TheBlueMatt merged commit 7adc624 into lightningdevkit:main Oct 30, 2025
23 of 25 checks passed
@TheBlueMatt TheBlueMatt mentioned this pull request Oct 30, 2025
Merged
@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Oct 30, 2025

Backported to 0.2 in #4193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt @ldk-reviews-bot @valentinewallace