Skip to content

Conversation

@TheBlueMatt
Copy link
Collaborator

crates.io will show any README/README.md which apears in the crate which is uploaded, but it doesn't consider the README from the workspace, only if its in the crate itself. Thus, we symlink the top-level README in all our crates in the hopes that it works.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.86%. Comparing base (28ef147) to head (1605291).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4191   +/-   ##
=======================================
  Coverage   88.85%   88.86%           
=======================================
  Files         180      180           
  Lines      137863   137876   +13     
  Branches   137863   137876   +13     
=======================================
+ Hits       122496   122521   +25     
+ Misses      12561    12553    -8     
+ Partials     2806     2802    -4     
Flag Coverage Δ
fuzzing 21.43% <ø> (-0.01%) ⬇️
tests 88.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1 @@
../README.md No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the approach AI is recommending to me is to add the "readme" field to our Cargo.tomls in each crate with a symlink to the top-level README.md. Don't think it matters much though as long as this works for crates.io

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sure, that's better.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

`crates.io` will show any README/README.md which apears in the
crate which is uploaded, but it doesn't consider the README from
the workspace, only if its in the crate itself.

Instead, add the `readme` field so that the workspace README also
gets uploaded.
@TheBlueMatt
Copy link
Collaborator Author

Switched to readme fields instead.

@TheBlueMatt TheBlueMatt merged commit c8b90d5 into lightningdevkit:main Oct 30, 2025
21 of 23 checks passed
@TheBlueMatt TheBlueMatt mentioned this pull request Oct 30, 2025
@TheBlueMatt
Copy link
Collaborator Author

Backported to 0.2 in #4193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants