Fix clippy::mismatched-lifetime-syntaxes #3997
Conversation
|
I've assigned @joostjager as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
==========================================
- Coverage 88.94% 88.92% -0.02%
==========================================
Files 174 174
Lines 124575 124578 +3
Branches 124575 124578 +3
==========================================
- Hits 110797 110777 -20
- Misses 11278 11308 +30
+ Partials 2500 2493 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Clippy now says |
Ah I didn't fix all cases |
dunxen
force-pushed
the
2025-08-fixmismatched-lifetime-syntaxes
branch
2 times, most recently
from
d476838 to
d139d1a
Compare
Hiding a lifetime that's elided elsewhere is confusing. See: rust-lang/rust#138677
dunxen
force-pushed
the
2025-08-fixmismatched-lifetime-syntaxes
branch
2 times, most recently
from
5a3a3c9 to
646a80e
Compare
dunxen
force-pushed
the
2025-08-fixmismatched-lifetime-syntaxes
branch
from
646a80e to
b104f3a
Compare
|
Ugh, okay that should do it. |
| @@ -49,7 +49,8 @@ use bitcoin::hash_types::BlockHash; | |||
| use bitcoin::pow::Work; | |||
|
|
|||
| use lightning::chain; | |||
| use lightning::chain::Listen; | |||
| #[allow(unused_imports)] // This thinks trait imports are unused if they're use in macros :( | |||
There was a problem hiding this comment.
Is this a bug in clippy? Did we report it? In any case it might make sense to move the imports into the macros themselves.
There was a problem hiding this comment.
I think it is a bug honestly. I could only find an issue about a false positive related to this rule for rust-analyzer but this definitely is an issue with the rustc lint rule.
I'll dig some more and file an issue if there isn't one.
Edit: I also noticed the clippy --fix missed a bunch of instances of some rules it can actually fix. I'm not sure if it was the options/flags I used not cooperating but I'll treat it with some suspicion and possibly also file an issue.
| @@ -14192,6 +14192,7 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
It looks like this may actually be dead code, so we should probably remove it :)
|
Also, in what world is the new code more readable? WTF rustc... |
Honestly the "useless concat" rule messed up the pretty alignment we had :( |
Hiding a lifetime that's elided elsewhere is confusing.
See: rust-lang/rust#138677