Fix new CI failures #3898
Merged
Fix new CI failures #3898
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
`clippy` recently added a new lint that encourages the use of variables directly in format strings rather than as positional arguments. While its not the most critical thing, its right, but fixing it everywhere is a few hundred changes and not entirely worth it right now. Instead, we simply allow the new default lint and hope to get to it at some point.
TheBlueMatt
force-pushed
the
2025-06-fix-ci
branch
from
7bf3c0b to
e2a05a4
Compare
This lint fires when we do a swap with a value stored in a mutex, as it sees the `&mut x.lock().unwrap()` as a temporary which can be taken from, even though it is in fact not. See rust-lang/rust-clippy#15166
TheBlueMatt
force-pushed
the
2025-06-fix-ci
branch
from
9f100ff to
622544b
Compare
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.