-
Notifications
You must be signed in to change notification settings - Fork 418
Peer Storage (Part 3): Identifying Lost Channel States #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adi2011
wants to merge
16
commits into
lightningdevkit:main
Choose a base branch
from
adi2011:peer-storage/serialise-deserialise
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+390
−215
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bce1f8e
Write structs to serialise-deserialise Channels inside Peer-storage
adi2011 92ff141
Remove #[rustfmt::skip] from fn write
adi2011 2d75670
Serialise ChannelMonitors and send them over inside Peer Storage
adi2011 aff1e57
Determine if we have lost data
adi2011 d86d30c
test: Modify test_peer_storage to check latest changes
adi2011 895beba
fixup: Serialise ChannelMonitors and send them over inside Peer Storage
adi2011 4c7b886
fixup: Write structs to serialise-deserialise Channels inside Peer-st…
adi2011 23fea08
fixup: Determine if we have lost data
adi2011 993581d
fixup: Serialise ChannelMonitors and send them over inside Peer
adi2011 2fb0486
fixup: Write structs to serialise-deserialise Channels inside peer-st…
adi2011 6267a10
fixup: Serialise ChannelMonitors and send them over inside Peer Storage
adi2011 34eb62d
fixup: Determine if we have lost data
adi2011 03bb2f0
fixup: Serialise ChannelMonitors and send them over inside Peer Storage
adi2011 8766784
fixup: Serialise ChannelMonitors and send them over inside Peer Storage
adi2011 e3de698
fixup: Write structs to serialise-deserialise Channels inside peer-st…
adi2011 c9baefb
fixup: Determine if we have lost data
adi2011 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a bit cleaner by using the proposed iterator
skip
ing approach in the loop below, maybe while simply keeping track of which monitors we already wrote?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will address this in the next fixup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this is still unaddressed?