Add onion failure packet length check to prevent out of bounds error #3686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
==========================================
- Coverage 89.25% 89.24% -0.02%
==========================================
Files 155 155
Lines 119959 119982 +23
Branches 119959 119982 +23
==========================================
+ Hits 107069 107077 +8
- Misses 10276 10283 +7
- Partials 2614 2622 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arik-so
reviewed
Mar 26, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Fixes an oversight in the refactor in commit ea0f099 when moving the decoding of the packet.
joostjager
force-pushed
the
fix-slice-out-of-bounds
branch
from
62c1205 to
10fe63d
Compare
arik-so
approved these changes
Mar 26, 2025
valentinewallace
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in the refactor in commit ea0f099 when moving the decoding of the packet.
This created a serious problem where a too short failure message received from downstream could crash the node. Added test coverage also.
Found via fuzzing.