Require `LengthLimitedRead` for structs that always drain reader #3640

valentinewallace · 2025-03-03T23:21:33Z

ldk-reviews-bot · 2025-03-03T23:21:35Z

👋 Thanks for assigning @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

valentinewallace · 2025-03-03T23:25:41Z

Looking for concept ACKs before fixing fuzz!

valentinewallace · 2025-03-03T23:32:22Z

Also do we also want to do the same for LengthReadableArgs? It's only used for onion{message,payment} payload decodes at the moment and the usage doesn't look problematic, but we could...

codecov · 2025-03-04T18:27:29Z

Codecov Report

Attention: Patch coverage is 58.04878% with 86 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (e6267d3) to head (6d13257).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/wire.rs	28.33%	35 Missing and 8 partials ⚠️
lightning/src/ln/msgs.rs	77.10%	3 Missing and 16 partials ⚠️
lightning/src/util/ser.rs	79.16%	2 Missing and 3 partials ⚠️
lightning/src/offers/invoice.rs	0.00%	4 Missing ⚠️
lightning/src/offers/offer.rs	0.00%	4 Missing ⚠️
lightning/src/offers/refund.rs	0.00%	4 Missing ⚠️
lightning-liquidity/src/lsps0/ser.rs	0.00%	3 Missing ⚠️
lightning-liquidity/src/manager.rs	0.00%	2 Missing ⚠️
lightning/src/ln/channelmanager.rs	50.00%	1 Missing ⚠️
lightning/src/offers/invoice_request.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3640      +/-   ##
==========================================
+ Coverage   89.24%   90.37%   +1.12%     
==========================================
  Files         155      155              
  Lines      119269   127304    +8035     
  Branches   119269   127304    +8035     
==========================================
+ Hits       106442   115050    +8608     
+ Misses      10231     9722     -509     
+ Partials     2596     2532      -64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arik-so

I think this makes a ton of sense, and not seeing any issues with any of the commits (though the whitespace one is also in 3620)

ldk-reviews-bot · 2025-03-05T08:45:18Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

arik-so · 2025-03-05T08:46:22Z

nit: might point out in the last commit message that the remaining structs are the ones not covered by impl_writeable_msg

arik-so · 2025-03-05T22:43:09Z

nit: squash the formatting commit in between getting the second ACK and merging.

ldk-reviews-bot · 2025-03-05T23:42:32Z

🔔 1st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

TheBlueMatt · 2025-03-06T00:50:56Z

lightning/src/util/ser.rs

-	/// Reads a `Self` in from the given [`LengthRead`].
-	fn read_from_fixed_length_buffer<R: LengthRead>(reader: &mut R) -> Result<Self, DecodeError>;
+	/// Reads a `Self` in from the given [`FixedLengthReader`].
+	fn read_from_fixed_length_buffer<'a, R: Read>(


We should either use a trait here, rather than forcing a FixedLengthReader, or we should remove LengthRead entirely (which looks ~unused now?). It'd be kinda nice to use a trait, I think, but maybe you thought it wouldn't be strict enough? I guess we could kinda just rename LengthRead as LengthLimiedRead and describe the semantics?

Haha I thought you said several times offline that LengthRead as-is wasn't sufficient so I went with the stricter option... I'll move forward with just renaming the current trait and adding docs.

Errr, I meant LengthReadable isn't sufficient. I don't think we have to fix it by forcing a LengthLimitingReader, but doing so is fine, I just wanted to highlight that we are leaving LengthRead unused here, and should remove it, but also that we could use that with suffucient method/trait renames.

TheBlueMatt · 2025-03-06T00:51:35Z

fuzz/src/chanmon_consistency.rs

@@ -1101,7 +1101,9 @@ pub fn do_test<Out: Output>(data: &[u8], underlying_out: Out, anchors: bool) {
 											// update_fail_htlc as we do when we reject a payment.
 											let mut msg_ser = update_add.encode();
 											msg_ser[1000] ^= 0xff;
-											let new_msg = UpdateAddHTLC::read(&mut Cursor::new(&msg_ser)).unwrap();
+											let mut cursor = Cursor::new(&msg_ser);


nit: we don't actually need a Cursor, we can just &mut &msg_ser[..]. Same elsewhere in this commit. Would be nice to slowly phase out Cursor as we touch it.

I started making this change, had to implement LengthLimitedRead for &[u8]. It ended up being weird because the Read implementation for a slice advances the slice to point to the yet-unread part, which means that LengthLimitedRead::total_bytes will be inaccurate after any part of the struct is read...

I'm not sure this is the way to go, when reading a TrampolinePacket for example it "successfully" read but due to this subtlety it didn't read the whole packet.

Hmm, I almost prefer it that way? Like, having a "how many bytes are in the buffer" call is weird cause the caller may have already read many bytes. "How many bytes are left in the buffer" is a way more sensible question to ask, IMO.

TheBlueMatt · 2025-03-06T00:54:05Z

lightning/src/offers/offer.rs

@@ -1033,8 +1034,10 @@ impl OfferContents {
 	}
 }

-impl Readable for Offer {
-	fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
+impl LengthReadable for Offer {


Don't we need to do this for all the other bolt 12 structs too?

Did this and a few other places in ser.rs.

valentinewallace · 2025-03-07T19:54:47Z

Will fix the build and a few more instances where LengthReadable is needed in a few

lightning/src/ln/wire.rs

See prior two commits. When deserializing objects via this macro, there is no length prefix so the deser code will read the provided reader until it runs out of bytes. Readable is not an appropriate trait for this situation because it should only be used for structs that are prefixed with a length and know when to stop reading. LengthReadable instead requires that the caller supply only the bytes that are reserved for this struct.

Easier to review the previous commit this way.

Continuing the work of the last few commits, here we require that some LN gossip messages be read from a length limiting reader. The messages' updates are separated into their own commit because they definitely should use a length limited reader but they also require breaking out of the ser macros. We can't use the macros because each message contains a non-TLV field that will always consume the rest of the reader, while the ser macros only support reading non-TLV fields that know when to stop reading.

When deserializing lightning messages, many consume the reader until it is out of bytes, or could in the future if new fields or TLVs are added. Therefore, it's safer if they are only provided with readers that limit how much of the byte stream will be read. Many of the relevant LN messages were updated in a prior commit when we transitioned impl_writeable_msg to require length limiting readers, here we finish the job.

When reading a raw LSP message specifically, it will consume the provided reader until it is out of bytes. Readable is not an appropriate trait for this situation, and over the past few commits we've been transitioning any struct that always reads-to-end to require a length limited reader. This is less error-prone because there is no risk of a bug being introduced because a custom message read more data than it was supposed to from the provided reader.

Continuing the work over the past few commits, we want to transition any structs that always consume the entire provided reader when being deserialized to require a length-limiting reader. To do this we actually require all the offers' underlying ser wrappers to be read from a length-limiting reader as well, since these wrappers will always read-to-end in general. Some of the ser macros needed updating for this, which is fine because all TLV values were already read from a length-limiting reader.

valentinewallace · 2025-03-12T19:47:43Z

Got rid of an unused lifetime (surprised there's no warning for that):

diff --git a/lightning/src/ln/wire.rs b/lightning/src/ln/wire.rs
index 20e1ca789..1bb7c7448 100644
--- a/lightning/src/ln/wire.rs
+++ b/lightning/src/ln/wire.rs
@@ -238,7 +238,7 @@ impl<T: core::fmt::Debug + Type + TestEq> Message<T> {
 /// # Errors
 ///
 /// Returns an error if the message payload could not be decoded as the specified type.
-pub(crate) fn read<'a, R: LengthLimitedRead, T, H: core::ops::Deref>(
+pub(crate) fn read<R: LengthLimitedRead, T, H: core::ops::Deref>(
        buffer: &mut R, custom_reader: H,
 ) -> Result<Message<T>, (msgs::DecodeError, Option<u16>)>
 where
@@ -249,7 +249,7 @@ where
        do_read(buffer, message_type, custom_reader).map_err(|e| (e, Some(message_type)))
 }

-fn do_read<'a, R: LengthLimitedRead, T, H: core::ops::Deref>(
+fn do_read<R: LengthLimitedRead, T, H: core::ops::Deref>(
        buffer: &mut R, message_type: u16, custom_reader: H,
 ) -> Result<Message<T>, msgs::DecodeError>
 where

arik-so · 2025-03-12T20:00:09Z

lightning/src/ln/wire.rs

should this commit remain or be squashed out pre-merge?

I assume you're referring to the rustfmtone? No reason to squash, IMO. Anything that helps a reviewer now helps a reviewer trying to understand the code in three years and it doesn't violate our "each commit should, on its own, build and pass tests" rule.

arik-so

looks great! Is it feasible to have a version of impl_writeable that uses LengthReadable so some of those structs can be reverted to using a macro call for the serialization implementation?

valentinewallace · 2025-03-12T20:40:48Z

looks great! Is it feasible to have a version of impl_writeable that uses LengthReadable so some of those structs can be reverted to using a macro call for the serialization implementation?

I felt weird using LengthReadable for non-TLV fields because the reader is not actually length-limiting them, each field is still free to consume the full buffer 🤔 also it was only 3 structs so wasn't sure it was worth it.

arik-so · 2025-03-12T20:47:20Z

fair enough!

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This is a temporary workaround to avoid introducing a big refactoring right now. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This changes are needed since [1] is landed on mainline. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need some temporary workaround to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This changes are needed since [1] is landed on mainline. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need this change to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This changes are needed since [1] is landed on mainline. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

@valentinewallace

When introducing the LengthLimitedRead trait in [1], for some serialization macros we need this change to avoid that we have the following compilation error error[E0277]: the trait bound `Bolt12Invoice: Readable` is not satisfied --> lightning/src/util/ser_macros.rs:1243:35 | 1243 | Ok($st::$tuple_variant_name($crate::util::ser::Readable::read(reader)?)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Readable` is not implemented for `Bolt12Invoice` | ::: lightning/src/events/mod.rs:2463:1 | 2463 | / impl_writeable_tlv_based_enum_legacy!(PaidInvoice, 2464 | | ; 2465 | | (0, Bolt12Invoice), 2466 | | (2, StaticInvoice) 2467 | | ); | |_- in this macro invocation | = help: the following other types implement trait `Readable`: () (A, B) (A, B, C) (A, B, C, D) (A, B, C, D, E) (A, B, C, D, E, F) (A, B, C, D, E, F, G) AnnouncementSigsState and 200 others = note: this error originates in the macro `impl_writeable_tlv_based_enum_legacy` (in Nightly builds, run with -Z macro-backtrace for more info) This changes are needed since [1] is landed on mainline. [1] lightningdevkit#3640 Co-Developed-by: @valentinewallace Suggested-by: @valentinewallace Signed-off-by: Vincenzo Palazzo <[email protected]>

valentinewallace force-pushed the 2025-03-fixed-len-readable branch from 6f66ebb to 47916c1 Compare March 3, 2025 23:24

valentinewallace force-pushed the 2025-03-fixed-len-readable branch from 47916c1 to 792fcf0 Compare March 4, 2025 18:18

valentinewallace marked this pull request as ready for review March 4, 2025 21:04

ldk-reviews-bot requested a review from arik-so March 4, 2025 21:05

valentinewallace mentioned this pull request Mar 4, 2025

Client-side of static invoice server #3618

Open

valentinewallace added the weekly goal Someone wants to land this this week label Mar 4, 2025

arik-so reviewed Mar 5, 2025

View reviewed changes

valentinewallace force-pushed the 2025-03-fixed-len-readable branch 2 times, most recently from 36698bb to b95f2ce Compare March 5, 2025 21:09

arik-so previously approved these changes Mar 5, 2025

View reviewed changes

valentinewallace requested a review from TheBlueMatt March 5, 2025 23:42

TheBlueMatt reviewed Mar 6, 2025

View reviewed changes

valentinewallace changed the title ~~Require FixedLengthReadable for structs that always drain reader~~ Require LengthLimitedRead for structs that always drain reader Mar 7, 2025

valentinewallace dismissed arik-so’s stale review via db17178 March 7, 2025 19:37

valentinewallace force-pushed the 2025-03-fixed-len-readable branch from b95f2ce to db17178 Compare March 7, 2025 19:37

valentinewallace force-pushed the 2025-03-fixed-len-readable branch 6 times, most recently from 3ddcf9c to c6ee09b Compare March 7, 2025 22:23

valentinewallace force-pushed the 2025-03-fixed-len-readable branch from 2f4c0de to 6d13257 Compare March 11, 2025 22:03

TheBlueMatt requested a review from arik-so March 12, 2025 18:50

TheBlueMatt previously approved these changes Mar 12, 2025

View reviewed changes

lightning/src/ln/wire.rs Outdated Show resolved Hide resolved

valentinewallace added 6 commits March 12, 2025 15:46

Rustfmt wire.rs

50745bf

Easier to review the previous commit this way.

valentinewallace dismissed TheBlueMatt’s stale review via 94f8952 March 12, 2025 19:47

valentinewallace force-pushed the 2025-03-fixed-len-readable branch from 6d13257 to 94f8952 Compare March 12, 2025 19:47

arik-so reviewed Mar 12, 2025

View reviewed changes

arik-so approved these changes Mar 12, 2025

View reviewed changes

TheBlueMatt approved these changes Mar 13, 2025

View reviewed changes

TheBlueMatt merged commit c355ea4 into lightningdevkit:main Mar 13, 2025
25 of 27 checks passed

valentinewallace mentioned this pull request Mar 13, 2025

[RFC] Implement a way to do BOLT 12 Proof of Payment #3593

Merged

tnull mentioned this pull request Mar 31, 2025

Fix fuzz failure due to unexpected length in router target #3692

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require `LengthLimitedRead` for structs that always drain reader #3640

Require `LengthLimitedRead` for structs that always drain reader #3640

valentinewallace commented Mar 3, 2025

ldk-reviews-bot commented Mar 3, 2025 •

edited

Loading

valentinewallace commented Mar 3, 2025

valentinewallace commented Mar 3, 2025

codecov bot commented Mar 4, 2025 •

edited

Loading

arik-so left a comment

ldk-reviews-bot commented Mar 5, 2025

arik-so commented Mar 5, 2025

arik-so commented Mar 5, 2025

ldk-reviews-bot commented Mar 5, 2025

TheBlueMatt Mar 6, 2025

valentinewallace Mar 6, 2025 •

edited

Loading

TheBlueMatt Mar 6, 2025

TheBlueMatt Mar 6, 2025

valentinewallace Mar 6, 2025 •

edited

Loading

TheBlueMatt Mar 6, 2025

TheBlueMatt Mar 6, 2025

valentinewallace Mar 7, 2025 •

edited

Loading

valentinewallace commented Mar 7, 2025

valentinewallace commented Mar 12, 2025

arik-so Mar 12, 2025

TheBlueMatt Mar 12, 2025

arik-so left a comment

valentinewallace commented Mar 12, 2025

arik-so commented Mar 12, 2025

Require LengthLimitedRead for structs that always drain reader #3640

Require LengthLimitedRead for structs that always drain reader #3640

Conversation

valentinewallace commented Mar 3, 2025

ldk-reviews-bot commented Mar 3, 2025 • edited Loading

valentinewallace commented Mar 3, 2025

valentinewallace commented Mar 3, 2025

codecov bot commented Mar 4, 2025 • edited Loading

Codecov Report

arik-so left a comment

Choose a reason for hiding this comment

ldk-reviews-bot commented Mar 5, 2025

arik-so commented Mar 5, 2025

arik-so commented Mar 5, 2025

ldk-reviews-bot commented Mar 5, 2025

TheBlueMatt Mar 6, 2025

Choose a reason for hiding this comment

valentinewallace Mar 6, 2025 • edited Loading

Choose a reason for hiding this comment

TheBlueMatt Mar 6, 2025

Choose a reason for hiding this comment

TheBlueMatt Mar 6, 2025

Choose a reason for hiding this comment

valentinewallace Mar 6, 2025 • edited Loading

Choose a reason for hiding this comment

TheBlueMatt Mar 6, 2025

Choose a reason for hiding this comment

TheBlueMatt Mar 6, 2025

Choose a reason for hiding this comment

valentinewallace Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

valentinewallace commented Mar 7, 2025

valentinewallace commented Mar 12, 2025

arik-so Mar 12, 2025

Choose a reason for hiding this comment

TheBlueMatt Mar 12, 2025

Choose a reason for hiding this comment

arik-so left a comment

Choose a reason for hiding this comment

valentinewallace commented Mar 12, 2025

arik-so commented Mar 12, 2025

Require `LengthLimitedRead` for structs that always drain reader #3640

Require `LengthLimitedRead` for structs that always drain reader #3640

ldk-reviews-bot commented Mar 3, 2025 •

edited

Loading

codecov bot commented Mar 4, 2025 •

edited

Loading

valentinewallace Mar 6, 2025 •

edited

Loading

valentinewallace Mar 6, 2025 •

edited

Loading

valentinewallace Mar 7, 2025 •

edited

Loading