Fix overly spammy TRACE logging in async onion message event handling (main)
#3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently introduced `TRACE`-level logging for event handling. However, in onion messenger we'd now log (twice, actually) every time `process_events_async` is called, which is very very spammy. Here we fix this by short-cutting to only proceed when we actualy have any event futures to poll.
wpaulino
approved these changes
Jan 7, 2025
arik-so
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3507, just towards the main branch.
In #3449, we introduced
TRACE-level logging for event handling. However, in onion messenger we'd now log (twice, actually) every timeprocess_events_asyncis called, which is very very spammy:Here we fix this by short-cutting to only proceed when we actualy have any event futures to poll.